Theme JSON: Extract util to get valid block style variations #61030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Backport for these PHP changes can be found at: WordPress/wordpress-develop#6479 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
May 29, 2024
Extracts the repeated collection of valid block style variations into a util that can be reused or updated in a single place for future work around extending block style variations. Backports WordPress/gutenberg#61030. Props aaronrobertshaw, audrasjb. Fixes #61121. git-svn-id: https://develop.svn.wordpress.org/trunk@58228 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 29, 2024
Extracts the repeated collection of valid block style variations into a util that can be reused or updated in a single place for future work around extending block style variations. Backports WordPress/gutenberg#61030. Props aaronrobertshaw, audrasjb. Fixes #61121. Built from https://develop.svn.wordpress.org/trunk@58228 git-svn-id: http://core.svn.wordpress.org/trunk@57691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
May 29, 2024
Extracts the repeated collection of valid block style variations into a util that can be reused or updated in a single place for future work around extending block style variations. Backports WordPress/gutenberg#61030. Props aaronrobertshaw, audrasjb. Fixes #61121. Built from https://develop.svn.wordpress.org/trunk@58228 git-svn-id: https://core.svn.wordpress.org/trunk@57691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Note: The changes in this PR are being split out from #57908 to make that more manageable
What?
Extracts the repeated collection of valid block style variations into a util that can be reused or updated in a single place for future work around extending block style variations.
Why?
Minor improvement to maintainability and readability.
Testing Instructions
npm run test:unit:php:base -- --filter WP_Theme_JSON_Gutenberg_TestScreenshot