Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/background image theme source #61401

Closed
wants to merge 21 commits into from
Closed

Add/background image theme source #61401

wants to merge 21 commits into from

Commits on May 6, 2024

  1. Supporting background.backgroundImage.source === "theme" relative paths

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b8e0f0b View commit details
    Browse the repository at this point in the history

  2. This is an experimental commit to test out how to: 

    - get the theme directory URI, and
- ensure background styles are parsed for theme.json and pattern/template files
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    540ef0e View commit details
    Browse the repository at this point in the history

  3. Roll back API changes and insert into editor settings under `currentT… 

    …heme` both parent and child dir

Update tests to check for image paths with leading slash

Revert rogue tab
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    da8ff40 View commit details
    Browse the repository at this point in the history

  4. If we pass a 'baseUrl' to the style engine, it will it append it to a… 

    …ll url-like paths.

Revert rogue space
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e57766a View commit details
    Browse the repository at this point in the history

  5. Rolls back f7bf075

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    774d299 View commit details
    Browse the repository at this point in the history

  6. Removed useBlockProps and now editing style object directly

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    fb406b0 View commit details
    Browse the repository at this point in the history

  7. Remove unused "parentDirectoryURI" prop in block editor settings 

    Added/updated unit tests

Bad horsie
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    95b80dd View commit details
    Browse the repository at this point in the history

  8. Yes, spacing.

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a284a5e View commit details
    Browse the repository at this point in the history

  9. Unit test no styles

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    59ec346 View commit details
    Browse the repository at this point in the history

  10. Getting URI from themes API response

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6156f07 View commit details
    Browse the repository at this point in the history

  11. Switching to experimental

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    668d982 View commit details
    Browse the repository at this point in the history

  12. Testing get_theme_file_uri on the backend and duping the background i… 

    …mage on the frontend.
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    738d2d3 View commit details
    Browse the repository at this point in the history

  13. Just a commit to explore adding a private selector to mimic get_theme… 

    …_file_uri (would be extracted into a new PR)

Haven't worked out global styles yet. CSS rules might need to be injected into the DOM???
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3ae580a View commit details
    Browse the repository at this point in the history

  14. whoops

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    77199b8 View commit details
    Browse the repository at this point in the history

  15. Resolving urls in theme.json 

    Feature complete, but hacky
    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    50fe66d View commit details
    Browse the repository at this point in the history

  16. Resolve URLs when building styles insteadof in the merged settings

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1ac09f1 View commit details
    Browse the repository at this point in the history

  17. Cleaning up unused methods

    @ramonjd
    ramonjd committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9f011b5 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. yay

    @ramonjd
    ramonjd committed May 7, 2024
    Configuration menu
    Copy the full SHA
    dfe1914 View commit details
    Browse the repository at this point in the history

  2. Yes, we have a new hook

    @ramonjd
    ramonjd committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e411ab5 View commit details
    Browse the repository at this point in the history

  3. Rolling back core data changes

    @ramonjd
    ramonjd committed May 7, 2024
    Configuration menu
    Copy the full SHA
    93e570a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Experimental commit

    @ramonjd
    ramonjd committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b69971b View commit details
    Browse the repository at this point in the history