Editor: Move the sidebar component to the editor package #61497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
Mamaduka,
jameskoster,
jasmussen,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -136 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 8, 2024
Comment on lines
+2
to
+3
| document: 'edit-post/document', | ||
| block: 'edit-post/block', |
There was a problem hiding this comment.
Are we keeping the old namespace for now? Let's note that we should update these when sidebar-related store actions are also unified.
There was a problem hiding this comment.
We can't change these for BC reasons unfortunately. We discussed this with @fabiankaegy in a previous PR and this was the best tradeoff
Mamaduka
approved these changes
May 8, 2024
jameskoster
approved these changes
May 8, 2024
|
The classnames changed; plugins that used to target the sidebar with their CSS have now regressed. |
|
Hey @sybrew, sorry for the breakage. Classnames and dom elements are not considered public APIs per our guidelines https://developer.wordpress.org/block-editor/contributors/code/backward-compatibility/#class-names-and-dom-updates That said, if we can ensure things don't break as we iterate on the UI, we're happy to do so. Can you share which classnames are you thinking about? Do you mind opening an issue with all the details. |
|
It's OK. I've detailed it here: sybrew/the-seo-framework@5ee3395. We are continuing to rely on the meta box API until I find an opportunity to improve upon that, so I am not directly interacting with React. The meta box implementation is still quite ugly, so now that I got your attention, please consider implementing this UI fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
We're in a middle of an effort to merge the post and site editors under the @wordpress/editor abstraction. As part of this, this PR moves the Sidebar component from the edit-post to the editor package.
The idea is that on a follow-up PR, I'll be removing the sidebar that is implemented in the edit-site package and just replace it with the one that is on the editor package (for both editors). I preferred to do this in two steps to avoid a huge PR.
Testing Instructions
Please test the sidebar (block and document) of the post editor. There should be no change compared to trunk.