Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sidebar close buttons to left side #61514

Closed
wants to merge 5 commits into from
Closed

Move sidebar close buttons to left side #61514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da1dcc9
Move close x to left side of block inserter sidebar
jeryj May 9, 2024
853a7b3
Move list view close button to left side
jeryj May 9, 2024
ce15ff2
Put complimentary sidebar close button on left side
jeryj May 9, 2024
35dfe19
Fix positioning on editor styles and settings sidebar close button
jeryj May 9, 2024
a19c69a
Remove repeated property
jeryj May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-edit-mode/settings-header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.components-panel__header.edit-site-sidebar-edit-mode__panel-tabs {
padding-left: 0;
padding-left: $grid-unit-10;

.components-button.has-icon {
padding: 0;
Expand Down
4 changes: 2 additions & 2 deletions packages/editor/src/components/inserter-sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@

.block-editor-inserter-sidebar__header {
border-bottom: $border-width solid $gray-300;
padding-right: $grid-unit-10;
padding-left: $grid-unit-10;
display: flex;
justify-content: space-between;

.block-editor-inserter-sidebar__close-button {
order: 1;
align-self: center;
margin-right: $grid-unit-20;
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/editor/src/components/list-view-sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
}
.editor-list-view-sidebar__header {
display: flex;
padding-left: $grid-unit-10;
border-bottom: $border-width solid $gray-300;
}
.editor-list-view-sidebar__close-button {
background: $white;
order: 1;
align-self: center;
margin-right: $grid-unit-15;
margin-right: $grid-unit-20;
}
}

Expand Down
3 changes: 1 addition & 2 deletions packages/editor/src/components/sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.components-panel__header.editor-sidebar__panel-tabs {
padding-left: 0;
padding-right: $grid-unit-20;
padding-left: $grid-unit-10;

.components-button.has-icon {
padding: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/interface/src/components/complementary-area-header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ const ComplementaryAreaHeader = ( {
) }
tabIndex={ -1 }
>
{ children }
{ toggleButton }
{ children }
</div>
</>
);
Expand Down
5 changes: 3 additions & 2 deletions packages/interface/src/components/complementary-area-header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,24 @@

.interface-complementary-area-header {
background: $white;
padding-right: $grid-unit-15; // Reduced padding to account for close buttons.
padding-left: $grid-unit-10; // Reduced padding to account for close buttons.
gap: $grid-unit-10; // Always ensure space between contents and close buttons.
justify-content: flex-start;

.interface-complementary-area-header__title {
margin: 0;
}

.components-button.has-icon {
display: none;
margin-left: auto;

~ .components-button {
margin-left: 0;
}

@include break-medium() {
display: flex;
margin-right: $grid-unit-20;
}
}
}
Loading