Editor: Move the starter template options to the editor package. #61665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
scruffian,
jameskoster,
jasmussen,
kevin940726 and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -160 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The steps to reproduce work as intended! However there's some jumpy and choppy animation that I'm not sure how to describe. There appears to be some blinking going on, as show in this gif:
That same blinking is not present in trunk, where the animation is smooth and fluid. |
|
I'll try to look but in my test, the same glitch happen on trunk as well. |
|
I see, you're right! Then the trunk glitch is a result of a recent unrelated PR that must've been merged. I wish I'd recorded trunk, which I tested before this PR. I was on an older version of trunk before I git pulled — so something else must've been merged between yesterday and today to cause this. |
|
@jasmussen Yes, I think there's a bug in trunk where the "start options" for pages are shown for templates as well and they override the templates modal. I just included a fix in the last commit of this PR. |
|
I think it's not really clear why we have two modals for "starter options", one for templates and one for pages but unifying the two can be done separately, for now I just fixed the bug. |
jasmussen
approved these changes
May 15, 2024
|
Flaky tests detected in b471ddf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9092570629
|
|
Hopefully these modals can probably be supplanted by an assembler-like experience down the road. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR just moves the StartTemplateOptions to the editor package. In theory this should have enabled the "starter modal" when creating templates from the post editor but for the moment it doesn't because there's a small difference between the "create template" button of the site editor and the post editor.
Aligning these two is harder and I'm not sure which path is the best or if they should be aligned (because they are triggered in two different places so I'm leaving that out of this PR.
Testing Instructions
1- Go to the "templates" page in the site editor
2- Create a custom template
3- you should be provided with a modal to choose from template starters.