Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Bindings: Move logic to core functions instead of using a hook #61817

Closed
wants to merge 18 commits into from
Closed

Block Bindings: Move logic to core functions instead of using a hook #61817

wants to merge 18 commits into from

Commits on May 28, 2024

  1. WIP: Move bindings logic to getBlockAttributes

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    39fd742 View commit details
    Browse the repository at this point in the history

  2. WIP: Move bindings setAttributes logic to updateBlockBindings

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    8914de2 View commit details
    Browse the repository at this point in the history

  3. Pass only select to getValue functions

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3bcd8d0 View commit details
    Browse the repository at this point in the history

  4. Remove old editor hook

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0606f21 View commit details
    Browse the repository at this point in the history

  5. Add fallback to postId until context is ready

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b86e0a1 View commit details
    Browse the repository at this point in the history

  6. Remove setValue post-meta code

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a45ef7c View commit details
    Browse the repository at this point in the history

  7. Simplify fallback conditional

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a5f0396 View commit details
    Browse the repository at this point in the history

  8. Change bindings destructuring

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3a2f62b View commit details
    Browse the repository at this point in the history

  9. Check canBindAttribute in updateBlockAttributes

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5e71d5e View commit details
    Browse the repository at this point in the history

  10. Update unit tests to expect a dispatch

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    facc4c9 View commit details
    Browse the repository at this point in the history

  11. Add conditional in block

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ec71b74 View commit details
    Browse the repository at this point in the history

  12. Don't use getBlockAttributes inside getValue

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b624727 View commit details
    Browse the repository at this point in the history

  13. Revert "Don't use getBlockAttributes inside getValue" 

    This reverts commit 0e91129.
    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a0cca30 View commit details
    Browse the repository at this point in the history

  14. Avoid processing bindings recursively

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3fdbc64 View commit details
    Browse the repository at this point in the history

  15. Access context through selector

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    cd12515 View commit details
    Browse the repository at this point in the history

  16. Update getBlockAttributes logic

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    01058e7 View commit details
    Browse the repository at this point in the history

  17. Don't use fallbacks

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4b83b29 View commit details
    Browse the repository at this point in the history

  18. Unlock private selector and action

    @SantosGuillamot
    SantosGuillamot committed May 28, 2024
    Configuration menu
    Copy the full SHA
    629056c View commit details
    Browse the repository at this point in the history