-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Omit default parameters from pages, template parts, and patterns #62372
Fix: Omit default parameters from pages, template parts, and patterns #62372
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +34 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Flaky tests detected in fbc286d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9402895286
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Thanks for the fix.
…#62372) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]>
…#62372) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]>
…WordPress#62372) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]>
This was cherry-picked to the wp/6.6 branch. |
Fixes: #60709
Fixes the first bug @youknowriad identified.
Testing Instructions
1- Go to pages: The url should be
wp-admin/site-editor.php?postType=page
2- Click "drafts": The url becomes something like
/wp-admin/site-editor.php?postType=page&activeView=drafts
.3- Go back to "all pages" Verify the url is still
wp-admin/site-editor.php?postType=page
.Repeat these steps for template parts and patterns verify that when switching views and going back to all view the URL is still the same