Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal component #6261

Merged
merged 77 commits into from
Jul 4, 2018
Merged

Modal component #6261

merged 77 commits into from
Jul 4, 2018

Commits on Apr 18, 2018

  1. Initial implementation modal

    Alexander Botteram committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    bf9f287 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. removed style prop assignment causing error

    Alexander Botteram committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    aba9636 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Set default mount node to #wpwrap

    Alexander Botteram committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    b0700fb View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. Implemented default styling

    Alexander Botteram committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    66367dd View commit details
    Browse the repository at this point in the history

  2. Improved styling

    Alexander Botteram committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    aca49d0 View commit details
    Browse the repository at this point in the history

  3. Applied code review feedback to with-focus-contain HOC

    Alexander Botteram committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    3a5d75c View commit details
    Browse the repository at this point in the history

  4. Added eslint ignore for jsx-a11y/no-static-element-interactions

    Alexander Botteram committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    371e66b View commit details
    Browse the repository at this point in the history

  5. Implemented withGlobalEvents HOC

    Alexander Botteram committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    bd48b5a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. withGlobalEvents HOC now forwards refs

    Alexander Botteram committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    809bfdd View commit details
    Browse the repository at this point in the history

  2. Replace lodash defer with withSafeTimeout

    Alexander Botteram committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    47219be View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary return statements

    Alexander Botteram committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    9b93633 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Created separate styling rules

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    de29a46 View commit details
    Browse the repository at this point in the history

  2. Added documentation for forwardRef function

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    4a1b2c4 View commit details
    Browse the repository at this point in the history

  3. Made mount location for modal configurable

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    1092fbd View commit details
    Browse the repository at this point in the history

  4. Renamed elementId to appElementId for clarity

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    44d91d3 View commit details
    Browse the repository at this point in the history

  5. Added noop for when no reg is provided in forwardRef

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    4aef9b6 View commit details
    Browse the repository at this point in the history

  6. Fixed error in EditorProvider

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    5c0568c View commit details
    Browse the repository at this point in the history

  7. Fix eslint errors

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    887193d View commit details
    Browse the repository at this point in the history

  8. Fixed incorrectly bound function

    Alexander Botteram committed May 1, 2018
    Configuration menu
    Copy the full SHA
    b0c4d82 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Modal now by default mounts to the body and hides all other elements

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    f25b989 View commit details
    Browse the repository at this point in the history

  2. hideApp no longer unhides elements that already had a aria-hidden=tru… 

    …e attribute and ignores script tags
    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    c360742 View commit details
    Browse the repository at this point in the history

  3. Improved a11y and updated documentation

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    984ef8e View commit details
    Browse the repository at this point in the history

  4. Updated documentation

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    6563c63 View commit details
    Browse the repository at this point in the history

  5. Removed forwardRef from element|

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    59255ff View commit details
    Browse the repository at this point in the history

  6. Changed default close label to Close dialog

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    c6ee481 View commit details
    Browse the repository at this point in the history

  7. Add modal-open className to body when modal is opened

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    17b7957 View commit details
    Browse the repository at this point in the history

  8. Added documentation to modal/index.js

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    c4b433b View commit details
    Browse the repository at this point in the history

  9. Removed aria-modal=true and explained why in aria-helper.js

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    cca2a0e View commit details
    Browse the repository at this point in the history

  10. Documented modal/frame.js

    Alexander Botteram committed May 2, 2018
    Configuration menu
    Copy the full SHA
    21a722c View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. Merge branch 'master' into add/modal

    @xyfi
    xyfi authored May 8, 2018
    Configuration menu
    Copy the full SHA
    9313ecb View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. Merge branch 'master' into add/modal

    @atimmer
    atimmer committed May 23, 2018
    Configuration menu
    Copy the full SHA
    f487f22 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. Merge branch 'master' into add/modal

    @abotteram
    abotteram committed May 29, 2018
    Configuration menu
    Copy the full SHA
    a66f5b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add/modal' of https://github.com/WordPress/gutenberg in… 

    …to add/modal
    @abotteram
    abotteram committed May 29, 2018
    Configuration menu
    Copy the full SHA
    359774d View commit details
    Browse the repository at this point in the history

  3. Addressed eslint issues

    @abotteram
    abotteram committed May 29, 2018
    Configuration menu
    Copy the full SHA
    e7a8f4f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2018

  1. Polish the visuals a bit.

    Joen Asmussen committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    94a3216 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Merge branch 'master' into add/modal

    @abotteram
    abotteram committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    064adbc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add/modal' of https://github.com/WordPress/gutenberg in… 

    …to add/modal
    @abotteram
    abotteram committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    832b1ac View commit details
    Browse the repository at this point in the history

  3. Disabled jsx-a11y/no-static-element-interactions in render function o… 

    …f withFocusContain instead of whole file
    @abotteram
    abotteram committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    6ac30dd View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. Merge branch 'master' into add/modal

    @abotteram
    abotteram committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    349b068 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. Merge branch 'master' into add/modal

    @abotteram
    abotteram committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    d1d2ba6 View commit details
    Browse the repository at this point in the history

  2. Addressed CR concerns

    @abotteram
    abotteram committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    eda32a6 View commit details
    Browse the repository at this point in the history

  3. Removed unused variable

    @abotteram
    abotteram committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    dde71f2 View commit details
    Browse the repository at this point in the history

  4. Replaced focus.tabbables.find from @wordpress/utils with @wordpress/dom

    @abotteram
    abotteram committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    ca8512a View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. Merge branch 'master' into add/modal

    @abotteram
    abotteram committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    afdaa2c View commit details
    Browse the repository at this point in the history

  2. Fixed failing tests after updating react-test-renderer to version 16.… 

    …4.1 for forwardRef support
    @abotteram
    abotteram committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    b6ef31f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2018

  1. CSS Tweaks

    @abotteram
    abotteram committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    b74d1e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. Fixed error when clicking outside of the modal

    @abotteram
    abotteram committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    dbac197 View commit details
    Browse the repository at this point in the history

  2. Move focus to first element with tabindex=-1 on mount

    @abotteram
    abotteram committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    61ac955 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. Make sure the dic the modal is renderd in is apprended to the documen… 

    …t's body/ DOM is ready before the modal is rendered
    @abotteram
    abotteram committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    d94e4ef View commit details
    Browse the repository at this point in the history

  2. Addressed minor codestyle issues in frame.js

    @abotteram
    abotteram committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    6eb3886 View commit details
    Browse the repository at this point in the history

  3. Fixed bug when opening modal the second time

    @abotteram
    abotteram committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    ee6f520 View commit details
    Browse the repository at this point in the history

  4. Removed unused import

    @abotteram
    abotteram committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    ca59960 View commit details
    Browse the repository at this point in the history

  5. replaced react-click-outside with internal withFocusOutside HOC

    @abotteram
    abotteram committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    e2a50a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2018

  1. Merge branch 'master' into add/modal

    @abotteram
    abotteram committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    010f223 View commit details
    Browse the repository at this point in the history

  2. Replaced withFocusContain with withConstrainedTabbing

    @abotteram
    abotteram committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    9968113 View commit details
    Browse the repository at this point in the history

  3. Replaced withFocusOutside with react-click-outside again

    @abotteram
    abotteram committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    5dc9b58 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2018

  1. Replaced @wordpress/utils keycodes with @wordpress/keycodes in frame.js

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    7f82944 View commit details
    Browse the repository at this point in the history

  2. don't pass props.aria.labelledby to frame div when props.contentLabel… 

    … is provided
    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    146f562 View commit details
    Browse the repository at this point in the history

  3. Added logic and tests for aria-helper to not hide (implicitely) live … 

    …regions
    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    30ab946 View commit details
    Browse the repository at this point in the history

  4. Removed isOpen props from the modal

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    bd1050b View commit details
    Browse the repository at this point in the history

  5. Removed the ability to add inline styles to the modal

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    d5f50d1 View commit details
    Browse the repository at this point in the history

  6. Removed useless css

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    2a0c916 View commit details
    Browse the repository at this point in the history

  7. Removed redundant z-index

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    9400adc View commit details
    Browse the repository at this point in the history

  8. Add full page overlay

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    a956732 View commit details
    Browse the repository at this point in the history

  9. Don't render h1 tag when no title is provided

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    0679405 View commit details
    Browse the repository at this point in the history

  10. Made modal screen-verlay full screen

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    4e3bb1a View commit details
    Browse the repository at this point in the history

  11. generate unique id for modal labelledby attribute

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    12dd5fe View commit details
    Browse the repository at this point in the history

  12. Replaced function scoped array liveRegionAriaRoles with file scoped c… 

    …onstant LIVE_REGION_ARIA_ROLES
    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    f607330 View commit details
    Browse the repository at this point in the history

  13. Removed check whtehr forwardedRef is defined

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    40cc3f9 View commit details
    Browse the repository at this point in the history

  14. Minor JSDoc improvement

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    0590e39 View commit details
    Browse the repository at this point in the history

  15. Removed styles from defaultProps

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    6f57d08 View commit details
    Browse the repository at this point in the history

  16. Documentation improvements

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    c547404 View commit details
    Browse the repository at this point in the history

  17. don't add labelledBy attribute to modal frame when no title is present

    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    4eba6c7 View commit details
    Browse the repository at this point in the history

  18. Don't add unique id to headingId when aria.labelledby prop is provide… 

    …d, also added aria.labelledby change logic
    @abotteram
    abotteram committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    9ee5b83 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2018

  1. Components: Reorder component lifecycle as first class members

    @aduth
    aduth committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    1a0bf75 View commit details
    Browse the repository at this point in the history

  2. Components: Use withInstanceId to generate modal heading id

    @aduth
    aduth committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    8778706 View commit details
    Browse the repository at this point in the history

  3. Components: Fix modal withInstanceId import reference

    @aduth
    aduth committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    6a43d9f View commit details
    Browse the repository at this point in the history