-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Global styles panel header buttons text overlap for 'Show button text labels' #63243
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +13 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Temporary fix for #61761
A more solid solution should be implemented by changing the design and not placing buttons in the panels header in the first place. This PR overrides the Button component CSS, which isn't ideal but it is worth noting the 'Show button text labels' feature itself overrides the base component CSS. An alternative solution is being explored in #61763
Additionally, makes the size of the Close button consistent with the size of the other buttons.
What?
The buttons text overlaps.
Why?
Overlapping text isn't readable.
How?
Makes the button width be
auto
when 'Show button text labels' is enabled.Makes the Close button use the
compact
size so that it is consistent with the other buttons.Testing Instructions
window.wp.data.dispatch( 'core/preferences' ).set( 'core', 'showIconLabels', true )
window.wp.data.dispatch( 'core/preferences' ).set( 'core', 'showIconLabels', false )
Testing Instructions for Keyboard
Screenshots or screencast
Overlapping text - Before: English and italian
After:
Close button size before (all buttons focused to better illustrate):
After: