Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve theme.json test failure messages by pretty printing css for a more accurate diff #64077

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Improve theme.json test failure messages by pretty printing css for a more accurate diff #64077

merged 3 commits into from
Jul 31, 2024

Commits on Jul 30, 2024

  1. Add basic formatting function and apply to one test 

    WIP

Add comment
    @talldan
    talldan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7f209f2 View commit details
    Browse the repository at this point in the history

  2. Add assertSameCSS expectation which outputs pretty printed test failu… 

    …re along with raw css for updating the test

Update accidentally committed test failure

Fix expected,actual order and minimize diff

Fix - make sure the actual is output in addition to the pretty printed failure, not the expected

Update test expectation so test passes

Revert "Update test expectation so test passes"

This reverts commit c9f655a.

Update test expectation so test passes
    @talldan
    talldan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ce6a6a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Convert comment to docblock

    @talldan
    talldan committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    2276f02 View commit details
    Browse the repository at this point in the history