Interactivity API: Update iterable signals when deepMerge() adds new properties
#65135
Conversation
DAreRodz
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 7b7e0cf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10753358050
|
| @@ -277,12 +277,13 @@ const deepMergeRecursive = ( | |||
| ) => { | |||
| if ( isPlainObject( target ) && isPlainObject( source ) ) { | |||
| for ( const key in source ) { | |||
| const isNew = ! ( key in target ); | |||
There was a problem hiding this comment.
Maybe "hasNewData" or "hasNewProperties" defines better the issue.
There was a problem hiding this comment.
Here, isNew refers to the current key inside the loop. But that's a good point anyway; we could move the signal update outside the loop. 🤔
What?
Fixes
deepMerge()to update the corresponding internal signals for property iteration (i.e.,...obj,Object.keys( obj ),Reflect.ownKeys( obj ), etc.Why?
When a
deepMerge()call adds new properties to an object, the correspondingiterablesignal should be updated to ensure subscribed directives react to changes.How?
Modifying the corresponding signal for the target object when necessary.
Testing Instructions
A unit test was added that didn't pass before the bug fix.