-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing control: Replace sides dropdwon with link button #65193
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -11.1 kB (-0.62%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in 981583a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10791432670
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM, and it works as advertised; thank you!
I left a comment regarding the wording of the label.
packages/block-editor/src/components/spacing-sizes-control/linked-button.js
Show resolved
Hide resolved
packages/block-editor/src/components/spacing-sizes-control/linked-button.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels much simpler. Like it.
One tiny detail: let's make the "Margin" and "Padding" labels in the tooltip lowercase, to match others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me 🎉
- The controls still work as expected in my testing ✅
- I can see "padding" and "margin" are both lowercase in the button tooltip ✅
This PR appears to have made the block spacing UI unavailable if the theme defines a default gap for blocks. For example, the TT4 theme defines a default block gap for the Buttons block. If you access the global styles for the Buttons block, you’ll see something like this: Before this PR was merged, it looked like this: However, this is not ideal, and since the Buttons block supports the axial gap, it should look like this: This issue has also been reported here: #64971 (review) My guess is that it has to do with updating the |
@t-hamano Your are right. It is because the function In #65371 the function is restored to its original code and included additional condition and it should now be fixed. |
What?
This changes removes sides dropdown from the
SpacingSizesControl
(Padding and Margin), and replaces it with a link button.First iteration of #63963
Note: no updates to icons in this iteration.
Testing Instructions
horizontal & vertical
view andall sides
custom view.Testing Instructions for Keyboard
Screenshots or screencast