Fix: Moving the last page item to the the trash causes a crash. #65236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
Mamaduka,
youknowriad,
jasmussen and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Nice, thanks for working on this. |
Mamaduka
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you, @jorgefilipecosta!
The fix works as expected, and it makes sense to add this check.
jorgefilipecosta
deleted the
fix/moving-the-last-page-item-to-the-trash-causes-a-crash
branch
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue found by @jasmussen, where when there is only a single page available on the all-pages view. Moving the page to the trash crashes the application.
Testing Instructions
Go to the site editor -> pages.
On the all pages view move all the pages to the trash so there is only a single page left.
Now move that single page to the trash and verify everything worked well on trunk a crash happens.