Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt to zoom out separator #65392

Merged
merged 9 commits into from
Sep 27, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ _::-webkit-full-page-media, _:future, :root .has-multi-selection .block-editor-b
justify-content: center;
font-size: $default-font-size;
font-family: $default-font;
color: $black;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be $gray-900.

$black: #000; // Use only when you truly need pure black. For UI, use $gray-900.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe you used $black because it needed that level of contrast?

If so let's add a comment to explain why we're using it.

Copy link
Contributor

@draganescu draganescu Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels on that gray we need black.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh the contrast would be insufficient otherwise. Thanks for clarifying 👍

font-weight: normal;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen Updated to force normal weight 👍


.is-zoomed-out & {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@draganescu Maybe this class got removed?

Expand Down
Loading