Revert "Allow multi-select on iOS Safari/touch devices" #65414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6aeba74.
|
Size Change: -581 B (-0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Actually, this does fix it. We were testing it wrong. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
I will check today if there's anything we can do to fix it to avoid a revert. Otherwise it's fine. |
t-hamano
reviewed
Sep 25, 2024
Comment on lines
-37
to
+32
| if ( ! containsSelection ) { | ||
| if ( event.target !== element ) { |
There was a problem hiding this comment.
I think we just need to keep the code here as is. Otherwise, the following two problems will occur:
- Formatting is not applied when formatted text is copied continuously
- Links cannot be pasted into formatted text
This problem was reported in #63434, and I tried to solve this problem in #63779, but #63671 ended up solving this problem as result. Please see this discussion for why such code is needed.
trunk (expected)
expected.mp4
This PR (not expected)
not-expected.mp4
There was a problem hiding this comment.
@t-hamano Let's maybe reopen your PR and fix it again separately.
|
Addition: Confirmed that this PR also fixes #65547. |
ellatrix
approved these changes
Sep 25, 2024
|
I believe it was clean. |
andrewserong
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 26, 2024
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 68e47d0 |
2 tasks
2 tasks
|
It looks like the original PR also affected Kanji conversion on MacOS. See #65675. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #63671
Testing to see if reverting fixes #64928.