-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilise role attribute property #65484
base: trunk
Are you sure you want to change the base?
Conversation
const __experimentalHasContentRoleAttribute = jest.fn( () => false ); | ||
const hasContentRoleAttribute = jest.fn( () => false ); | ||
getBlockEditingMode.registry = { | ||
select: jest.fn( () => ( { | ||
__experimentalHasContentRoleAttribute, | ||
hasContentRoleAttribute, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these tests be moved to selectors
tests now?
return true; | ||
} | ||
if ( __experimentalRole === 'content' ) { | ||
deprecated( '__experimentalRole attribute', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecated( '__experimentalRole attribute', { | |
deprecated( '__experimentalRole property', { |
Am I right?
Size Change: +101 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Do you plan to include it in WordPress 6.7?
Looking at the unit tests now |
I think that's a decision that's up for debate. The "Zoom Out mode" feature does make use of contentOnly but not in a way that requires us to know about which blocks are "content blocks". The recent "Select mode" work uses We might want to buy some more time for the API to stablise alongside the new modes, or alternatively we could say the API that's been around for 2yrs is probably good to stablise. Opinions welcomed. |
Anyone have any idea why this test is failing on CI but passing locally? Going to try a rebase. |
4c28c28
to
7392224
Compare
What?
Stablises the
_experimentalRole
property of block attributes andallsome related selectors and utils.Note:
__experimentalHasContentRoleAttribute
has been made a private selector. Full backwards compatibility will remain until WP 6.8.Why?
This has been in use for 2 years and has not be stablised. With all the work on
contentOnly
going on it makes sense to look to stablise the APIs in order that block authors can be confident in making use of them.How?
__experimentalHasContentRoleAttribute
a private selector.__experimental
prefixed versions to new versions and throwsdepreciated()
warning__experimentalRole
prop.__experimental
prefixed functions and attribute props.Testing Instructions
hasContentRoleAttribute
API__experimentalGetBlockAttributesNamesByRole
API:The call to the experimental method should throw a deprecated notice.
Also check Editor doesn't crash when moving in / out of Zoom Out mode or the new "Edit" mode.
Registering a Block
Content Only Test Block
to the post and type something into the inputTesting Instructions for Keyboard
Screenshots or screencast