Block Directory: Fix downloadable block item alignment #65677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +28 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Sep 26, 2024
packages/block-directory/src/components/downloadable-block-list-item/style.scss
Show resolved
Hide resolved
Co-authored-by: Marco Ciampini <[email protected]>
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Block Directory: Fix downloadable block item alignment * Add a comment to explain the extra margin Co-authored-by: Marco Ciampini <[email protected]> * Fix indentation --------- Co-authored-by: Marco Ciampini <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 4188bbb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an alignment issue while installing custom block plugins from the block directory.
Why?
Just fixing a bug that I encountered while reviewing #65467 (review).
How?
We're adding some margin to the block icon's top element while installing. The reason is that while installing, we're hiding the rating bar, which is a bit wider (6px) than the icon container. When the rating bar is removed, it makes the icon container smaller, and that makes the rest of the content jump a bit. By adding those
6pxwhen installing the block, we keep the consistency.Ideally, this would refactor the markup, maybe keep more of the block icon, and make a better "installing" state, but this is work for another PR. For now, I'm just fixing a bug so it gets into WP 6.7.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Screen.Recording.2024-09-26.at.16.10.16.mov
Screen.Recording.2024-09-26.at.16.09.27.mov