Block bindings: Refactor passing select and dispatch instead of full Registry. #65710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Code Quality
|
Size Change: -45 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
SantosGuillamot
added
the
Backport to WP 6.7 Beta/RC
cbravobernal
requested review from
ellatrix,
ntwb,
nerrad,
ajitbohra,
tellthemachines and
artemiomorales
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
This change makes sense to me. We can always pass the whole registry if it is requested in the future, but for the time being, it seems safer this way. People shouldn't call dispatch from getValues, for example.
Additionally, it seems there are other examples where registry, select, dispatch are all passed as arguments like thunks or resolvers.
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
noisysocks
pushed a commit
that referenced
this pull request
Oct 1, 2024
…Registry. (#65710) * Try use select and dispatch instead of registry * Pass `select` to `canUserEditValue` * Pass `select` to `getFieldsList` * Fix `setValues` --------- Co-authored-by: cbravobernal <[email protected]> Co-authored-by: SantosGuillamot <[email protected]>
noisysocks
added
Backported to WP Core
|
Ignore the above, I've cherry-picked into |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…Registry. (WordPress#65710) * Try use select and dispatch instead of registry * Pass `select` to `canUserEditValue` * Pass `select` to `getFieldsList` * Fix `setValues` --------- Co-authored-by: cbravobernal <[email protected]> Co-authored-by: SantosGuillamot <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…of full Registry. (WordPress#65710)" This reverts commit 4e532d0.
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Pass
selectanddispatchtosetValuesandgetValuesinstead of the fullregistryobject.Why?
We don't need those full objects on the functions.
How?
Testing Instructions
CI Tests should pass.