Global Styles: fix screens crashing on exit animation #65790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
the
Global Styles
|
As noted by @t-hamano in the related PR, E2E tests are currently failing for an unrelated issue — core ticket: Core ticket: core.trac.wordpress.org/ticket/60666 |
|
Size Change: +86 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The ideal solution would be each Is this possible to pull off? At first sight it doesn't seem terribly hard. And it would be much better than patching the screen components one by one. |
|
I 100% agree with you, this PR was just an emergency patch to make sure that 19.4 doesn't ship with this bug — compared to the other "emergency fix" in #65765, this one has the advantage that the screen's contents are not removed while animating out.
I currently have little time to work on this — but if you feel like working on it, that would be great! And I'd be happy to pair / review. |
|
Thanks for the PR! If we include this PR in 19.4, do we not need to merge #65765? |
I think so, this could be an alternative to #65765. I don't have a strong preference on which solution to pick — #65765 is simpler but leads to a less refined animation, the one in this PR is more complex and needs to be tested well to make sure there are no unintended consequences. Or maybe we can work out a fix directly in |
Gutenberg 19.3 was released on September 25th. Gutenberg 19.4 will be released two weeks later, on October 9th. For reference, here is the Slack post where the preparation of Gutenberg 19.3 RC1 was announced: https://wordpress.slack.com/archives/C02QB2JS7/p1726624220894339 Maybe someone knows who is responsible for the Gutenberg 19.4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #65711
Alternative to #65765
Related to #64777
What?
This PR fixes a critical error that occurs when returning to the previous screen from the shadow presets panel or the font presets panel.
Why?
@t-hamano found that the problem was caused by #64777.
From this comment:
How?
Keep around the previous values of the params when they become undefined during an exit animation, as part of the suggestion in this comment.
Testing Instructions
Screenshots or screencast
Kapture.2024-10-01.at.15.47.37.mp4