Tests: Remove skipped tests which fail, enable those that pass #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have some skipped unit tests. 3 of them are disabled because
Enzymestill doesn't support React 16.3 and we should keep them until this is resolved. They estimate to publish new version of Enzyme in June. See enzymejs/enzyme#1513 (comment).However, we have also one test suite where tests are hidden behind the env flag. This PR removes this flag and removes all the failing tests. Let's keep those which pass and make sure they are kept up to date with the development process.
@aduth or @youknowriad - if you have an idea how to make the removed tests make pass, please add commit to this PR. Otherwise I will merge this PR as is later this week.
How has this been tested?
npm testTypes of changes
Remove unused code.
Checklist: