Use createBlock helper in place of manual block creation #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This means all the blocks returned already have |
aduth
added
[Feature] Block API
Isn't that what's already happening here? https://github.com/WordPress/gutenberg/blob/90cc25b/blocks/api/factory.js#L88-L90 |
@aduth no I'd update this to :
|
aduth
force-pushed
the
update/688-consistent-create-block
branch
from
8e5c6d5
to
baa6737
Compare
|
Thanks for the pointer @youknowriad . I've updated the factory method and updated the tests to assume blocks to be returned via |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #688
This pull request seeks to use the
wp.blocks.createBlockhelper consistently for creating blocks, particularly in block transforms.Testing instructions:
Verify that there are no regressions in changing between heading, text, and quote block types.