Embed: adjust width of iframe and inline toolbar. #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
commented
May 9, 2017
| position: relative; | ||
| width: 100%; | ||
| height: 0; | ||
| padding-bottom: 56.25%; /* 16:9 */ |
There was a problem hiding this comment.
just a hack to place the video for now
|
Nope, not that I know of. The padding trick is still the one I'd use, so 👍 from me. The problem is that iframes have no intrinsic aspect ratios, like a raw image has, so we have to set the height somehow. |
aduth
approved these changes
May 9, 2017
ellatrix
force-pushed
the
update/embed-tweaks
branch
from
5999ae1
to
4cd167a
Compare
ellatrix
force-pushed
the
update/embed-tweaks
branch
from
4cd167a
to
182fd3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jasmussen is there any other approach for responsive videos these days without having to know aspect ratio?
Closes #550