Restore captions for image and embed #7749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Jul 6, 2018
tofumatt
reviewed
Jul 6, 2018
|
|
||
| .wp-block-embed { | ||
| // Supply caption styles to images, even if the theme hasn't opted in. | ||
| // Reason being: the new markup, figcaptions, are not likely to be styled in the majority of existing themes, |
There was a problem hiding this comment.
Is this intended to be deprecated eventually, once themes know about this new markup? Or will we keep it?
This comment reads a bit like it's a stop-gap.
There was a problem hiding this comment.
I think we should phase it away, but don't want to rush it because it will cause a visual degradation at this moment.
This PR is a followup to #7624. It adds back the caption styles for images and embeds. This is because the majority of existing themes won't have styles to accommodate the new `figcaption` markup, and are likely to be styling the WP Captions instead. For those themes, if the caption styles live in the `theme.scss` file, the captions will appear unstyled or broken. Some time in the future, this can possibly be revisited and shuffled around.
|
Rebased because there was a failing preview end-to-end test, which could have been impacted (improved?) by the more recent merge of #7703. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #7624.
It adds back the caption styles for images and embeds. This is because the majority of existing themes won't have styles to accommodate the new
figcaptionmarkup, and are likely to be styling the WP Captions instead. For those themes, if the caption styles live in thetheme.scssfile, the captions will appear unstyled or broken.Some time in the future, this can possibly be revisited and shuffled around.