Add alignment buttons for embed #840
Conversation
|
Love it! Works great! 👍 👍 |
|
I notice that the toolbar position is a bit strange when it's "wide", but same for image. Let's address in a separate issue. |
This is being addressed largely in #812 |
There was a problem hiding this comment.
Worth nothing that if we do #830 These controls could be factorized.
LGTM 👍
| @@ -50,7 +50,7 @@ registerBlock( 'core/image', { | |||
| { | |||
| icon: 'align-center', | |||
| title: wp.i18n.__( 'Align center' ), | |||
| isActive: ( { align } ) => 'center' === align, | |||
| isActive: ( { align } ) => ! align || 'center' === align, | |||
There was a problem hiding this comment.
No align isn't same as center aligned, is it?
There was a problem hiding this comment.
Maybe I'm confusing this... It has the same style.
There was a problem hiding this comment.
It appears the same in the editor, but different on the front-end.
| none | center |
|---|---|
 |
 |
We should probably make this distinction more obvious in the editor though.
There was a problem hiding this comment.
Probably would be good to get #812 in, before fixing centering issues.
There was a problem hiding this comment.
I'm fine with reverting that part.
Shamelessly copied from the image block. See #729.