Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Redux Routine: Add Babel runtime dependency #8660

Merged
merged 4 commits into from
Aug 8, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 7, 2018

Related: #8096 (comment)

This pull request seeks to add @babel/runtime as a dependency of the @wordpress/redux-routine package, since its transpiled output includes a module dependency on this package.

This may need to be reconciled with updates to use fixed version dependency proposed in #8586.

Testing instructions:

Verify npm install

@aduth aduth added the [Package] Redux Routine /packages/redux-routine label Aug 7, 2018
@aduth aduth assigned gziolo and unassigned gziolo Aug 7, 2018
@aduth aduth requested a review from gziolo August 7, 2018 14:29
@gziolo gziolo force-pushed the fix/redux-routine-babel-runtime branch from 432f41e to 08f1fbe Compare August 8, 2018 06:48
@gziolo gziolo force-pushed the fix/redux-routine-babel-runtime branch from 08f1fbe to 80de958 Compare August 8, 2018 06:55
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after all fixes applied, in particular, all oddities with package-lock.json.

@gziolo gziolo added this to the 3.5 milestone Aug 8, 2018
@gziolo gziolo merged commit ea64a0f into master Aug 8, 2018
@gziolo gziolo deleted the fix/redux-routine-babel-runtime branch August 8, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Redux Routine /packages/redux-routine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants