Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages: Redux Routine: Remove fake timers from tests #8661

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Packages: Redux Routine: Remove fake timers from tests #8661

merged 1 commit into from
Aug 7, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 7, 2018

Related: #8096 (comment)

This pull request seeks to remove an explicit call to jest.useFakeTimers from within the tests for Redux Routine. Fake timers are enabled by default for all packagers.

Testing instructions:

Verify unit tests pass:

npm run test

@aduth aduth added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Redux Routine /packages/redux-routine labels Aug 7, 2018
@aduth aduth requested a review from gziolo August 7, 2018 14:29
@aduth aduth changed the title Redux Routine: Remove fake timers from tests Packages: Redux Routine: Remove fake timers from tests Aug 7, 2018
gziolo
gziolo approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix 🙇

@aduth aduth merged commit d9b3e6f into master Aug 7, 2018
@aduth aduth deleted the remove/redux-routine-fake-timers branch August 7, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Package] Redux Routine /packages/redux-routine [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @gziolo