Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS BUGFIX: Inspector Controls Dashicon vertical center correction #9902

Closed
wants to merge 1 commit into from
Closed

CSS BUGFIX: Inspector Controls Dashicon vertical center correction #9902

wants to merge 1 commit into from

Conversation

BenjaminZekavica
Copy link
Member

@BenjaminZekavica BenjaminZekavica commented Sep 14, 2018

Description

Inspector Controls Dashicons are no Center in the Y-axis. I have fix it now.

How has this been tested?

Now it works fine and correctly.

Screenshots

Before: https://www.imagebanana.com/s/big/1180/1keuVorY.png
After FIX: https://www.imagebanana.com/s/big/1180/i3uIdqr2.png

Types of changes

  • Add new CSS Code in file "editor/components/block-inspector/style.scss" @ Line 19
  • Dashicons now vert. correctly

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added the [Package] Components /packages/components label Sep 25, 2018
@jasmussen
Copy link
Contributor

Thank you for the pull request!

I believe that @chrisvanpatten merged in a different fix that should address the same issue, in #9828. Chris can you take a look and see if this is necessary? Applying this fix to master did not appear to make any difference for me.

@BenjaminZekavica
Copy link
Member Author

This bug is now also in Gutenberg. With this CSS Property it works now fine. I have test it :)

@chrisvanpatten
Copy link
Member

This is indeed fixed by #9828!

edit_homepage_ mindful _wordpress

@BenjaminZekavica Make sure you're testing in master; the bug is still present in 3.9 but will be fixed when 4.0 is released.

@chrisvanpatten
Copy link
Member

@BenjaminZekavica I'll close this up since the issue is fixed elsewhere but if you try testing in master and still run into issues, let me know and I can re-open and we can investigate further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants