-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that the changes necessary here are so minimal. The new Airflow arg for the version is a nice improvement.
The label check action hates when I submit a PR from the GitHub CLI 🙈 |
I do not understand... @dhruvkb do you have any idea what's going on here? The labels are correct but the check is still failing 🤔 Same with this PR! WordPress/openverse-api#530 |
@AetherUnbound that's super weird! I tried re-running the action manually and it still failed! Removing and re-applying the labels in the GitHub UI seemed to fix it, however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
Description
This PR updates Airflow to the latest version, v2.2.4. Unfortunately, this version does not yet support Python 3.10 (although that's happening soon! See: apache/airflow#19059).
I've moved the Airflow version to an argument at the top of the Airflow installation section - this should make it easier to find and update the version, rather than hunting through the Dockerfile to try and find it.
This also fixes some deprecations warnings regarding Airflow that were appearing in the test output.
Testing Instructions
just build
just test
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin