Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i18n check to plugin repo category #633

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Add i18n check to plugin repo category #633

merged 6 commits into from
Sep 25, 2024

Conversation

davidperezgar
Copy link
Member

Fixes #632

@davidperezgar davidperezgar linked an issue Sep 14, 2024 that may be closed by this pull request
Make available the i18 checks for Plugin Repo #632
Closed
@davidperezgar davidperezgar self-assigned this Sep 14, 2024
@davidperezgar
Copy link
Member Author

I've updated this to make it available this check in Repo as well. It's necessary for us.

@davidperezgar davidperezgar marked this pull request as ready for review September 22, 2024 09:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: akirk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar changed the title Check: don't use variables in textdomains and some issues related with internationalization Make available the i18 checks for Plugin Repo Sep 22, 2024
@davidperezgar davidperezgar changed the title Make available the i18 checks for Plugin Repo Make available by default the i18 checks for Plugin Repo Sep 22, 2024
@swissspidy
Copy link
Member

Looks like the Behat tests need updating as they‘re failing.

@swissspidy swissspidy changed the title Make available by default the i18 checks for Plugin Repo Add i18n check to plugin repo category Sep 22, 2024
@davidperezgar
Copy link
Member Author

Waiting for approval!

@swissspidy swissspidy added this to the 1.2.0 milestone Sep 25, 2024
@swissspidy swissspidy merged commit 59b89db into trunk Sep 25, 2024
28 checks passed
@swissspidy swissspidy deleted the 632-check-dont-use-variables-or-defines-as-text-domain-shortcuts branch September 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernilambar ernilambar ernilambar approved these changes

@swissspidy swissspidy swissspidy approved these changes

Assignees

@davidperezgar davidperezgar

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Make available the i18 checks for Plugin Repo
3 participants
@davidperezgar @swissspidy @ernilambar