Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Add custom sizes attribute to post body images. #629

Closed
wants to merge 6 commits into from
Closed

Add custom sizes attribute to post body images. #629

wants to merge 6 commits into from

Conversation

mor10
Copy link
Contributor

@mor10 mor10 commented Nov 17, 2018

Addresses #50. Replaces #411.

Dependent on WordPress/gutenberg#11973.

Add custom sizes attribute to images in post/page body. Provides custom values for "regular" and wide images and sets full images to the default.

Todo:

  • Test left/right aligned images (smaller than regular width.
  • Test gallery images.

@mor10
Copy link
Contributor Author

mor10 commented Nov 17, 2018

cc @azaozz @joemcgill @mtias

This was referenced Nov 17, 2018
Closed
Closed
@mor10
Copy link
Contributor Author

mor10 commented Nov 26, 2018

Now contingent on https://core.trac.wordpress.org/ticket/45407 and https://core.trac.wordpress.org/ticket/45406

@mtias mtias mentioned this pull request Nov 28, 2018
Closed
@mor10
Copy link
Contributor Author

mor10 commented Dec 2, 2018

Updated PR to reflect how the filter will eventually work once the block attributes for the containing block are available in the wp_calculate_image_sizes filter.

cc @joemcgill

@mor10 mor10 mentioned this pull request Dec 5, 2018
Closed
@kjellr
Copy link
Collaborator

kjellr commented Jan 14, 2019

This PR has been ported over as a patch on this Trac ticket: https://core.trac.wordpress.org/ticket/45985

@kjellr kjellr closed this Jan 14, 2019
@benlk benlk mentioned this pull request Aug 22, 2019
Open
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mor10 @kjellr