Skip to content

Commit

Permalink
Code Modernization: Rename parameters that use reserved keywords in `…
Browse files Browse the repository at this point in the history
…wp-includes/atomlib.php`.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the `$string` parameter to `$content` in `AtomParser::xml_escape()`.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

git-svn-id: https://develop.svn.wordpress.org/trunk@53239 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
SergeyBiryukov committed Apr 21, 2022
1 parent f341d73 commit 14d9ca8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/wp-includes/atomlib.php
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,10 @@ function is_declared_content_ns($new_mapping) {
return false;
}

function xml_escape($string)
function xml_escape($content)
{
return str_replace(array('&','"',"'",'<','>'),
array('&amp;','&quot;','&apos;','&lt;','&gt;'),
$string );
$content );
}
}

0 comments on commit 14d9ca8

Please sign in to comment.