Support the blockTypes and viewport_width props for remote patterns fetched from Pattern Directory
#3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns fetched from Pattern Directory
85 tasks
hellofromtonya
force-pushed
the
add/support-block_types-viewport_width-in-remote-patterns
branch
from
605432f
to
cf2cae5
Compare
src/wp-includes/block-patterns.php
Outdated
| * @param array $pattern Pattern as returned from the Pattern Directory API. | ||
| * @return array Normalized pattern. | ||
| */ | ||
| function _normalize_remote_pattern( $pattern ) { |
There was a problem hiding this comment.
I renamed to _normalize_remote_block_pattern.
There was a problem hiding this comment.
See #3967 (review), we should not be using underscore prefixes in Core. This is something that I was already advised by seasoned committers several years ago. While occasionally it gets overlooked, it's not a good practice. The recommendation is to simply mark the function with @access private.
I've updated this in 6f39a68.
hellofromtonya
approved these changes
Feb 6, 2023
felixarntz
reviewed
Feb 6, 2023
There was a problem hiding this comment.
@ntsekouras One naming nit-pick; otherwise this is good to go.
felixarntz
approved these changes
Feb 6, 2023
|
Committed in https://core.trac.wordpress.org/changeset/55234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57611
We need to add the support for
block_typesandviewport_widthprops for remote patterns fetched from Pattern Directory.With this support, we can fetch remote patterns and use them properly as suggestions where needed.
The addition of block_types field in Pattern Directory API was made here: WordPress/pattern-directory#111
GB PR: WordPress/gutenberg#47677
props @ryelle
Before
Screen.Recording.2023-02-02.at.11.35.59.AM.mov
After
Screen.Recording.2023-02-02.at.11.36.55.AM.mov
Testing Instructions
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.