Remove server-side redirection in site editor #4073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4070 has been committed, unblocking this PR ✅ Currently reviewing for committing. |
hellofromtonya
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
- Confirmed covers the changes from Move site editor 6.2 specific code to the right file gutenberg#48023 ✅
- Tested before and after > works as expected ✅
Ready for commit 👍
|
Committed via https://core.trac.wordpress.org/changeset/55338. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57716
Remove server-side redirection if missing postType and postId query args when visiting Site Editor.
This is not needed any more as the routing is handled client side.
Related GB PRs:
Testing instructions would be to click Appearance->Editor in WP admin and everything should work as before.
It requires this PR to land first: Update the WP packages with fixes prior to WP 6.2 beta 2 #4070
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.