Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport change. #4412

Closed
wants to merge 1 commit into from
Closed

Conversation

spacedmonkey
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/58231


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@oandregal
Copy link
Member

I see this backports WordPress/gutenberg#47833 and WordPress/gutenberg#48759 Noting so we don't forget linking this to the original gutenberg PRs and the props to t-hamano.

I also see that there is a related ticket https://core.trac.wordpress.org/ticket/58193 and that Felix mentioned he'll work on backporting everything WordPress/gutenberg#47833 (comment)

Changes seem fine to me, though.

@oandregal
Copy link
Member

There is no process for backports, it changes from person to person. I can share what I do when I backport and what I find helpful:

Not that this is mandatory in any way, though I've found it very helpful.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach seems good to me, and given that this is already been in Gutenberg for a while should be fine to commit.

@tellthemachines
Copy link
Contributor

Hi! To confirm, this is meant to be a separate piece from #4380?

I added this PR to the 6.3 board, please feel free to move it to "needs core commit" if it's good to go!

@spacedmonkey
Copy link
Member Author

@spacedmonkey
Copy link
Member Author

Hi! To confirm, this is meant to be a separate piece from #4380?

I added this PR to the 6.3 board, please feel free to move it to "needs core commit" if it's good to go!

@tellthemachines I committed as I wanted to unblock my ticket. Let's backport that separately.

@tellthemachines
Copy link
Contributor

Thanks @spacedmonkey !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants