Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Block Bindings API #5888

Closed
wants to merge 76 commits into from
Closed

Add the Block Bindings API #5888

wants to merge 76 commits into from

Commits on Jan 17, 2024

  1. Add the Block Bindings API

    @michalczaplinski
    michalczaplinski committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8720e12 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @artemiomorales
    artemiomorales committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8891169 View commit details
    Browse the repository at this point in the history

  3. Move tests to different directory

    @artemiomorales
    artemiomorales committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eac5b22 View commit details
    Browse the repository at this point in the history

  4. Fix bug wherein block content was erased

    @artemiomorales
    artemiomorales committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    39e52ed View commit details
    Browse the repository at this point in the history

  5. Update comment format for consistency

    @artemiomorales
    artemiomorales committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    82e70ff View commit details
    Browse the repository at this point in the history

  6. Move process_block_bindings_function to class-wp-block

    @michalczaplinski
    michalczaplinski committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6486471 View commit details
    Browse the repository at this point in the history

  7. WordPress capitalization dangit

    @michalczaplinski
    michalczaplinski committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    048330e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. PHPDoc formatting

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4a4b825 View commit details
    Browse the repository at this point in the history

  2. Add a better PHPDoc

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9a662e4 View commit details
    Browse the repository at this point in the history

  3. Add a new unit test covering the _process_block_bindings() function

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c92b6ac View commit details
    Browse the repository at this point in the history

  4. More fixes for formatting, capitalization and PHPDocs

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    abb56fb View commit details
    Browse the repository at this point in the history

  5. Add @SInCE to block-bindings.php

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e8b1195 View commit details
    Browse the repository at this point in the history

  6. Add version and since tags to class and methods

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    cc6c2c2 View commit details
    Browse the repository at this point in the history

  7. Add a comment on the block class

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    206b6b7 View commit details
    Browse the repository at this point in the history

  8. Update assertions in WP_Block_Bindings_Test class

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    dc8377a View commit details
    Browse the repository at this point in the history

  9. Update block binding registration function comment

    @michalczaplinski
    michalczaplinski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    751a459 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Change the signature of wp_block_bindings_register_source & WP_Bloc… 

    …k_Bindings::register_source to accept an array of [label, apply]
    @michalczaplinski
    michalczaplinski committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    423bb66 View commit details
    Browse the repository at this point in the history

  2. Add type hints for register_source() & replace_html()

    @michalczaplinski
    michalczaplinski committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d1b0d2e View commit details
    Browse the repository at this point in the history

  3. Add the missing array keys

    @michalczaplinski
    michalczaplinski committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9f2274d View commit details
    Browse the repository at this point in the history

  4. Apply WordPress/gutenberg#58055

    @michalczaplinski
    michalczaplinski committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    02f0ea3 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Make processing of bindings private to the class

    @artemiomorales
    artemiomorales committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9303e02 View commit details
    Browse the repository at this point in the history

  2. Update class name and method names

    @artemiomorales
    artemiomorales committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    30f4ed7 View commit details
    Browse the repository at this point in the history

  3. Remove the wp_block_bindings() function and create a static get_ins… 

    …tance() method instead
    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    940fb82 View commit details
    Browse the repository at this point in the history

  4. Rename register_block_bindings_source() to register()

    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    dbda027 View commit details
    Browse the repository at this point in the history

  5. Move the process_block_bindings & replace_html methods to the WP_bloc… 

    …k class
    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    34d9dd7 View commit details
    Browse the repository at this point in the history

  6. Rename WP_Block_Bindings to WP_Block_Bindings_Registry in missing places

    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    74bfae7 View commit details
    Browse the repository at this point in the history

  7. Rename class-wp-block-bindings.php to class-wp-block-bindings-registr… 

    …y.php
    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    013535e View commit details
    Browse the repository at this point in the history

  8. Rename $source_args to $source_properties to align with other similar… 

    … functions
    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    89e9833 View commit details
    Browse the repository at this point in the history

  9. Add is_registered() & get_registered()

    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0c931e0 View commit details
    Browse the repository at this point in the history

  10. Register block bindings on 'init' action hook

    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7b1ebe2 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'trunk' into feature/block-bindings-api

    @michalczaplinski
    michalczaplinski committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b0c300f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Fix incorrect loading of block bindings class

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e0b3883 View commit details
    Browse the repository at this point in the history

  2. Add validation to prevent sources from being registered twice

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2900bf5 View commit details
    Browse the repository at this point in the history

  3. Add 'core' namespace to built-in sources

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    26da23e View commit details
    Browse the repository at this point in the history

  4. Fix incorrect reading of sources

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    29213d8 View commit details
    Browse the repository at this point in the history

  5. Rename 'apply' to 'get_value_callback'

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4c3d892 View commit details
    Browse the repository at this point in the history

  6. Fix incorrect reading of registered sources

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    06a3930 View commit details
    Browse the repository at this point in the history

  7. Ensure unauthorized users don't read post meta

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f53121d View commit details
    Browse the repository at this point in the history

  8. Fix PHPCS errors

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5b8eb4a View commit details
    Browse the repository at this point in the history

  9. Rename sources using naming pattern for block types

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    45a96f8 View commit details
    Browse the repository at this point in the history

  10. Add context to translation

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    08ddb0a View commit details
    Browse the repository at this point in the history

  11. Update comments and revise to use proper array annotation

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3a16941 View commit details
    Browse the repository at this point in the history

  12. Update callback comment with return type details; fix PHPCS

    @artemiomorales
    artemiomorales committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1729f65 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Code quality improvements for the Block Bindings Registry

    @gziolo
    gziolo authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    9ea2c9a View commit details
    Browse the repository at this point in the history

  2. Ensure that code comments fit into the line length limit

    @gziolo
    gziolo authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fd090ab View commit details
    Browse the repository at this point in the history

  3. Updates to the test

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6ea69cd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into feature/block-bindings-api

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    15dea88 View commit details
    Browse the repository at this point in the history

  5. Remove the files already committed in WordPress#5965 and WordPress#5966.

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5893867 View commit details
    Browse the repository at this point in the history

  6. Update block bindings function call in class-wp-block.php

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d10b165 View commit details
    Browse the repository at this point in the history

  7. Add set_up to block-bindings tests

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    c324e65 View commit details
    Browse the repository at this point in the history

  8. Refactor block bindings tests

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a0d550a View commit details
    Browse the repository at this point in the history

  9. Fix block bindings registration unit test and test setup

    @michalczaplinski
    michalczaplinski committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    3f242d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Move tests to block-bindings directory

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d202e5d View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary attributes from the test

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2a20dee View commit details
    Browse the repository at this point in the history

  3. Incorporate PHP changes from WordPress/gutenberg#58337

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2b4cf33 View commit details
    Browse the repository at this point in the history

  4. Fix binding source arguments in WP_Block class

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8604e82 View commit details
    Browse the repository at this point in the history

  5. Test passing arguments to the source

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    65a7c09 View commit details
    Browse the repository at this point in the history

  6. Undo the changes in register.php

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1ceef1b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'trunk' into feature/block-bindings-api

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3d97457 View commit details
    Browse the repository at this point in the history

  8. Update the docstring for process_block_bindings

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5f397aa View commit details
    Browse the repository at this point in the history

  9. Update source_name parameter documentation in block-bindings.php and … 

    …class-wp-block-bindings-registry.php
    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f2a611b View commit details
    Browse the repository at this point in the history

  10. Refactor post_meta_source_callback function to use is_post_publicly_v… 

    …iewable() instead of checking post status directly
    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a1e1bac View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary condition for unregistering block bindings sources

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    26571a7 View commit details
    Browse the repository at this point in the history

  12. Fix access control logic in post_meta_source_callback function

    @michalczaplinski
    michalczaplinski committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d189f50 View commit details
    Browse the repository at this point in the history

  13. Optimize call to post_password_required()

    @artemiomorales
    artemiomorales committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d7201ce View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Update pattern source label and PHPDoc string.

    @michalczaplinski
    michalczaplinski committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    69ed754 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into feature/block-bindings-api

    @michalczaplinski
    michalczaplinski committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    951ca16 View commit details
    Browse the repository at this point in the history

  3. Update block bindings source labels

    @michalczaplinski
    michalczaplinski committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f10a4fe View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Wrap the block binding registrations with 'init' actions

    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0bec833 View commit details
    Browse the repository at this point in the history

  2. Use $this->block_type directly in replace_html method

    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3134faa View commit details
    Browse the repository at this point in the history

  3. Mark functions passed to init actions in block binding sources as pri… 

    …vate and add PHP docstrings
    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9491be3 View commit details
    Browse the repository at this point in the history

  4. Prefix block binding function names with _ to mark as private

    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c95b92f View commit details
    Browse the repository at this point in the history

  5. Update the function names again

    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3619e18 View commit details
    Browse the repository at this point in the history

  6. Prevent pattern and post meta sources from registering in unit tests

    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c8232ac View commit details
    Browse the repository at this point in the history

  7. Use call_user_func_array to call the source binding callback in WP_… 

    …Block class
    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    871cedc View commit details
    Browse the repository at this point in the history

  8. Validate that $block['attrs']['metadata']['bindings'] is an array i… 

    …n `process_block_bindings()`
    @michalczaplinski
    michalczaplinski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    604f7a2 View commit details
    Browse the repository at this point in the history