Editor: Define the labels of the pattern categories taxonomy #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'not_found' => __( 'No pattern categories found.' ), | ||
| 'popular_items' => __( 'Popular Pattern Categories' ), | ||
| 'search_items' => __( 'Search Pattern Categories' ), | ||
| 'separate_items_with_commas' => __( 'Separate pattern categories with commas' ), |
There was a problem hiding this comment.
For "pattern categories", we use different text cases that need to be consistent.
There was a problem hiding this comment.
separate_items_with_commas is lowercase for regular tags by default, so this seems correct.
There was a problem hiding this comment.
Yes, I did copy from the tags I think and adapted the labels.
There was a problem hiding this comment.
For Link Category taxonomy we use 'back_to_items' => __( '← Go to Link Categories' ), and for Pattern Category we use 'back_to_items' => __( '← Go to pattern categories' ), it should be 'back_to_items' => __( '← Go to Pattern Categories' ),
There was a problem hiding this comment.
Here's a follow-up #5930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/60322
In WordPress 6.5, the editor UI is going to be using a standard component for the taxonomies in the editor including the pattern categories. This means that all the labels need to be defined properly for this taxonomy.
This backports the change from WordPress/gutenberg#57094