Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPUnit tests for links_add_base_url function #5980

Closed
wants to merge 14 commits into from

Conversation

pbearne
Copy link

@pbearne pbearne commented Jan 30, 2024

A new PHPUnit test class, Tests_formatting_linksAddBaseUrl, has been introduced to increase the test coverage for the links_add_base_url function. The class includes multiple test scenarios, examining different combinations of attributes to verify the correct functioning of the function.

Trac ticket: https://core.trac.wordpress.org/ticket/60389

A new PHPUnit test class, Tests_formatting_linksAddBaseUrl, has been introduced to increase the test coverage for the links_add_base_url function. The class includes multiple test scenarios, examining different combinations of attributes to verify the correct functioning of the function.
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Expanded test cases in 'linksAddBaseUrl.php' to include cases for 'http', 'ftp' and 'ftps' bases in addition to the existing cases. Breadth of testing is enhanced with this consideration of more URL schemas.
Copy link

github-actions bot commented Mar 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, peterwilsoncc, jorbin, mukesh27, aristath.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming things and a realtive scheme test.

Please confirm any coding stanadards and results.

tests/phpunit/tests/formatting/linksAddBaseUrl.php Outdated Show resolved Hide resolved
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbearne Needs to fix the PHPCS fix.

@pbearne
Copy link
Author

pbearne commented Sep 23, 2024

@pbearne Needs to fix the PHPCS fix.

fixed

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peterwilsoncc
Copy link
Contributor

Merged r59162 / 636d748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants