-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit tests for links_add_base_url function #5980
Conversation
A new PHPUnit test class, Tests_formatting_linksAddBaseUrl, has been introduced to increase the test coverage for the links_add_base_url function. The class includes multiple test scenarios, examining different combinations of attributes to verify the correct functioning of the function.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Expanded test cases in 'linksAddBaseUrl.php' to include cases for 'http', 'ftp' and 'ftps' bases in addition to the existing cases. Breadth of testing is enhanced with this consideration of more URL schemas.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming things and a realtive scheme test.
Please confirm any coding stanadards and results.
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbearne Needs to fix the PHPCS fix.
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
A new PHPUnit test class, Tests_formatting_linksAddBaseUrl, has been introduced to increase the test coverage for the links_add_base_url function. The class includes multiple test scenarios, examining different combinations of attributes to verify the correct functioning of the function.
Trac ticket: https://core.trac.wordpress.org/ticket/60389