Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern overrides handler to retrieve attribute value from new values property #6055

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Feb 7, 2024

Backports the changes from WordPress/gutenberg#58596.

The gutenberg PR changes the data structure of the overrides data to allow it to be more flexible for future features.

Note that it might be best to commit this around the same time as gutenberg package updates land in core so that the block changes and core code changes are synchronized.

Trac ticket: https://core.trac.wordpress.org/ticket/60456


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Feb 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props talldanwp, gziolo.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: talldan <[email protected]>
Co-authored-by: gziolo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 7, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@gziolo
Copy link
Member

gziolo commented Feb 7, 2024

@talldan, when you are done with all the backports, it would be great to add some basic PHPUnit tests covering how Pattern Overrides work with block bindings. It could be on the _block_bindings_pattern_overrides_get_value level to start with. However, more useful would be to have some integration test that runs do_blocks( '<!-- wp:block {"ref":18,"overrides":{"AcqHKe":{"text":[1,"Hello"]}}} /-->' ) (I had the old format in my local instance).

@youknowriad
Copy link
Contributor

commit https://core.trac.wordpress.org/changeset/57585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants