HTML API: Fix unsupported insertion mode messages #7043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insertion modes may include instructions like "process the token in another insertion mode." This means that the step_in_X method may be called to process in the insertion mode _without_ changing the state of the insertion mode. This can result in unsupported errors that are incorrect. The bail messages for each step_in_ method should explicitly mention its insertion mode to ensure the error messages are correct.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
19 tasks
dmsnell
approved these changes
Jul 22, 2024
pento
pushed a commit
that referenced
this pull request
Jul 22, 2024
Insertion modes in an HTML parser may include instructions like "process the token in the IN HEAD insertion mode." The rules do not change the insertion mode of the parser, but the errors are triggered outside of the rules for the current insertion mode. These will be misleading when bailing on these instructions, because it will point someone to the wrong place in the code to find the source of the error. In this patch all of the bail-points due to lacking insertion mode support are hard-coded to better orient someone to the section of the code lacking support for handling the input HTML. Developed in #7043 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [58679]. Props: dmsnell, jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58781 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 22, 2024
Insertion modes in an HTML parser may include instructions like "process the token in the IN HEAD insertion mode." The rules do not change the insertion mode of the parser, but the errors are triggered outside of the rules for the current insertion mode. These will be misleading when bailing on these instructions, because it will point someone to the wrong place in the code to find the source of the error. In this patch all of the bail-points due to lacking insertion mode support are hard-coded to better orient someone to the section of the code lacking support for handling the input HTML. Developed in WordPress/wordpress-develop#7043 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [58679]. Props: dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58781 git-svn-id: http://core.svn.wordpress.org/trunk@58183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Jul 22, 2024
Insertion modes in an HTML parser may include instructions like "process the token in the IN HEAD insertion mode." The rules do not change the insertion mode of the parser, but the errors are triggered outside of the rules for the current insertion mode. These will be misleading when bailing on these instructions, because it will point someone to the wrong place in the code to find the source of the error. In this patch all of the bail-points due to lacking insertion mode support are hard-coded to better orient someone to the section of the code lacking support for handling the input HTML. Developed in WordPress/wordpress-develop#7043 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [58679]. Props: dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58781 git-svn-id: https://core.svn.wordpress.org/trunk@58183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insertion modes may include instructions like "process the token in
another insertion mode." This means that the step_in_X method may be
called to process in the insertion mode without changing the
state of the insertion mode.
This can result in unsupported errors that are incorrect.
The bail messages for each step_in_ method should explicitly
mention its insertion mode to ensure the error messages are
correct.
Trac ticket: https://core.trac.wordpress.org/ticket/61576
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.