-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed visibility #7482
Fixed visibility #7482
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In ongoing work to modularize the `WP_Debug_Data` class, several methods were added with `public` visibility. This patch sets the new methods to `private` as a measure to ensure optionality as the changes progress, since it's easier to move from private to public than the other way around. Developed in #7482 Discussed in https://core.trac.wordpress.org/ticket/61648 Follow-up to [58830], [58855], [58964], [59002], [59011], [59060], [59100]. Props apermo, jonsurrell. Fixes #61648. git-svn-id: https://develop.svn.wordpress.org/trunk@59164 602fd350-edb4-49c9-b593-d223f7449a82
In ongoing work to modularize the `WP_Debug_Data` class, several methods were added with `public` visibility. This patch sets the new methods to `private` as a measure to ensure optionality as the changes progress, since it's easier to move from private to public than the other way around. Developed in WordPress/wordpress-develop#7482 Discussed in https://core.trac.wordpress.org/ticket/61648 Follow-up to [58830], [58855], [58964], [59002], [59011], [59060], [59100]. Props apermo, jonsurrell. Fixes #61648. Built from https://develop.svn.wordpress.org/trunk@59164 git-svn-id: http://core.svn.wordpress.org/trunk@58559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In ongoing work to modularize the `WP_Debug_Data` class, several methods were added with `public` visibility. This patch sets the new methods to `private` as a measure to ensure optionality as the changes progress, since it's easier to move from private to public than the other way around. Developed in WordPress/wordpress-develop#7482 Discussed in https://core.trac.wordpress.org/ticket/61648 Follow-up to [58830], [58855], [58964], [59002], [59011], [59060], [59100]. Props apermo, jonsurrell. Fixes #61648. Built from https://develop.svn.wordpress.org/trunk@59164 git-svn-id: https://core.svn.wordpress.org/trunk@58559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixed visibilty for newly added functions prior 6.7 release.
CC @dmsnell
Namely:
Trac ticket: https://core.trac.wordpress.org/ticket/61648#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.