-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tested up to label and test matrix #155
Conversation
I realized that even after removing PHP 5.6 from the |
That is unrelated to your PR. The required builds are defined in the protected branch settings and the way the branch protection is set up for this repo it will now literally block every single PR from being merged. I just checked and while I can commit, I cannot change the branch protection, so you now have the not very enviable task to figure out who on this earth has admin rights for this repo and can set the branch protection to something a little more sane. In my opinion, the following changes need to be made:
Aside from the above, there are a number of PRs open (and rotting for over a year) which make various improvements to the GH Actions workflows. Those PRs should be merged with priority to keep things running smoothly and never be left to rot. I would merge them myself now, except due to the long time between when I pulled them and now and having to rebase them due to the branch protection settings, I can't merge them anymore with the failing PHP 5.6 build. In my opinion, we should also add a dependabot config to automatically update action runners as those are going out of date fast now too. All in all, it comes down to nobody taking ownership of this repo and that being problematic when changes need to be made/merged/released. |
Thanks for the suggestion @jrfnl , please let me know if I can help on those pending PRs from you. @vishnugopal, what do you think based on the suggestion above? Do we have permission to modify the settings? |
test.yml
How to test:
wp-env
to test, if you haven't installed it, please visit wp-env for instructions.wp-env.json
file at the root folder. For example, if your root folder isoss-importer
and you can clone the plugin under this folder. Create.wp.-env.json
file, you can change PHP version to the one you want to test with.wp-env start
to spin up the WordPresshttp://localhost:8888/wp-admin/admin.php?import=wordpress
and perform an import