Tools: Try adding infrastructure for PHPUnit tests #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9897577.
ryelle
commented
Oct 31, 2022
| "wp-coding-standards/wpcs": "2.*", | ||
| "wporg/wporg-repo-tools": "dev-trunk" | ||
| "wp-phpunit/wp-phpunit": "~6.0", |
There was a problem hiding this comment.
I'm pretty sure we don't need phpunit/phpunit or wp-phpunit/wp-phpunit since it's using the wp-env container & wp installation, but I've left it in from #204 in case it's necessary for running phpunit locally.
renintw
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be helpful to add unit tests for the global-font changes in #297, but we need the infrastructure in place first. This forks out the phpunit code from #204, and rebases it all to the current
trunk.To test:
yarnto install the wp-env depcomposer updateto install the new composer depsyarn test:phpto run the tests (currently just the demo test)The actions run on this PR should also include a unit-test action.