-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
single post #97
Comments
#24 is looking promising: #24 (comment) |
#99 seems to have fixed the Likes button. Design folks: there are still some issues with the appearance of likes and sharing buttons. Can we get a call as to whether or not it looks acceptable for a SotW demo? cc @kellychoffman @beafialho. |
Do you have an updated screenshot? I don't believe the test site is reflecting the latest changes. |
I think the test site is showing the latest changes for the sharing and like buttons, which is to say default styling: In my limited understanding we could style the sharing buttons, but not the Like button because it's an iframe. Is there a well-known method for doing that? @dd32 any ideas? |
After tracking down the section in figma, As far as I know, Jetpack likes can't be used in the manner suggested in the designs. There are ways to customise some of the iframe internals, but I'm not sure if this is still up-to-date: https://cfinke.wordpress.com/2013/04/18/customize-jetpack-like/ A custom block / custom open-source likes using w.org accounts could do that design though I'm sure.. |
Huh, nice find (@cfinke's post). I think for SotW we're best to just hide both of them. |
I agree, so I've disabled those Jetpack Features on this page |
Counting this as fixed for SotW. |
Hide likes/sharing if #24 isn't done in time.
The text was updated successfully, but these errors were encountered: