Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single post #97

Closed
Tracked by #83
tellyworth opened this issue Dec 2, 2021 · 8 comments
Closed
Tracked by #83

single post #97

tellyworth opened this issue Dec 2, 2021 · 8 comments
Labels
Help Wanted Extra attention is needed

Comments

@tellyworth
Copy link
Contributor

tellyworth commented Dec 2, 2021

Hide likes/sharing if #24 isn't done in time.

@tellyworth tellyworth mentioned this issue Dec 2, 2021
20 tasks
@tellyworth tellyworth added this to the State of the Word preview milestone Dec 2, 2021
@tellyworth
Copy link
Contributor Author

#24 is looking promising: #24 (comment)

@tellyworth tellyworth added the Help Wanted Extra attention is needed label Dec 2, 2021
@tellyworth
Copy link
Contributor Author

#99 seems to have fixed the Likes button.

Design folks: there are still some issues with the appearance of likes and sharing buttons. Can we get a call as to whether or not it looks acceptable for a SotW demo? cc @kellychoffman @beafialho.

@kellychoffman
Copy link
Collaborator

Do you have an updated screenshot? I don't believe the test site is reflecting the latest changes.

@tellyworth
Copy link
Contributor Author

I think the test site is showing the latest changes for the sharing and like buttons, which is to say default styling:
Screen Shot 2021-12-06 at 3 13 05 pm

In my limited understanding we could style the sharing buttons, but not the Like button because it's an iframe. Is there a well-known method for doing that? @dd32 any ideas?

@dd32
Copy link
Member

dd32 commented Dec 6, 2021

In my limited understanding we could style the sharing buttons, but not the Like button because it's an iframe. Is there a well-known method for doing that?

After tracking down the section in figma, As far as I know, Jetpack likes can't be used in the manner suggested in the designs.

There are ways to customise some of the iframe internals, but I'm not sure if this is still up-to-date: https://cfinke.wordpress.com/2013/04/18/customize-jetpack-like/

image
image

A custom block / custom open-source likes using w.org accounts could do that design though I'm sure..

@tellyworth
Copy link
Contributor Author

Huh, nice find (@cfinke's post). I think for SotW we're best to just hide both of them.

@dd32
Copy link
Member

dd32 commented Dec 6, 2021

I think for SotW we're best to just hide both of them.

I agree, so I've disabled those Jetpack Features on this page

@tellyworth
Copy link
Contributor Author

Counting this as fixed for SotW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants