Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Missing like and social sharing buttons #24

Open
3 of 5 tasks
coreymckrill opened this issue Aug 27, 2021 · 7 comments
Open
3 of 5 tasks

Jetpack: Missing like and social sharing buttons #24

coreymckrill opened this issue Aug 27, 2021 · 7 comments
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Question Needs input from others before actionable

Comments

@coreymckrill
Copy link
Contributor

coreymckrill commented Aug 27, 2021

The current News site includes these buttons at the bottom of single posts, and the new design also incorporates them.

As noted in #21, Jetpack does not yet have site blocks for the Like feature or for the social sharing buttons. There's an issue for Likes, but I haven't been able to find one for the sharing buttons.

Until Jetpack creates these site blocks, the only way I can see to include these features in block templates would be to create a custom block that simply outputs a server-side render of the two features. Are there other options?

Also of note, the new design calls for several style changes to the Like button and related content (such as the row of avatars of users who have already liked). However, since all of that content gets loaded via an iframe, I suspect that most customization is not possible.

  • Activate modules
  • Fix "Like" broken loading state
  • revert the hiding done in single post #97
  • Style Sharing to match mockup
  • Style Likes to match mockup
@coreymckrill coreymckrill added the [Type] Question Needs input from others before actionable label Aug 27, 2021
@iandunn
Copy link
Member

iandunn commented Aug 30, 2021

create a custom block that simply outputs a server-side render of the two features

👍🏻 . It'd be good to open an issue for the sharing buttons too.

since all of that content gets loaded via an iframe, I suspect that most customization is not possible.

👍🏻 . could also open an issue for that, seems like it's something most themes would want to do

@coreymckrill
Copy link
Contributor Author

Found the issue for the Sharing block: Automattic/jetpack#19694

@iandunn iandunn added this to the Initial Launch milestone Oct 14, 2021
@iandunn iandunn added Good First Issue Good for newcomers and removed Good First Issue Good for newcomers labels Oct 14, 2021
@iandunn iandunn changed the title Jetpack Likes and social sharing buttons Jetpack: Missing like and social sharing buttons Nov 4, 2021
@iandunn iandunn added the [Status] Blocked (external) Blocked by something outside our direct control label Nov 4, 2021
@iandunn iandunn mentioned this issue Nov 22, 2021
20 tasks
@iandunn
Copy link
Member

iandunn commented Nov 24, 2021

I'm guessing we'll be able to simply embed the shortcodes, like we did in #35 (comment)

@iandunn
Copy link
Member

iandunn commented Nov 24, 2021

Actually, I enabled the Sharing and Likes modules, and they're showing up now. The Like button is stuck in the loading state, though.

We'll need to style them too.

@dd32
Copy link
Member

dd32 commented Dec 2, 2021

I followed up on the Likes loading issue, this is ultimately a bug between Jetpack and Core. The Jetpack Likes script is registered too late for FSE themes, but loaded at the right time for Classic themes due to a load ordering difference between the types of themes.

https://core.trac.wordpress.org/ticket/54529 is a core work around.

A workaround for this site temporarily can be:

add_action( 'template_redirect', function() {
    Jetpack_Likes::instance()->load_styles_register_scripts();
} );

@dd32
Copy link
Member

dd32 commented Dec 6, 2021

Just noting that per #97 the share/like features are disabled temporarily for SOTW

@iandunn
Copy link
Member

iandunn commented Dec 15, 2021

👍🏻 I added them back now that it's over

@iandunn iandunn removed this from the Post-Launch Iteration 1 milestone Feb 25, 2022
@iandunn iandunn added this to the Post-Launch Iteration 2 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Question Needs input from others before actionable
Projects
None yet
Development

No branches or pull requests

4 participants