-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack: Missing like and social sharing buttons #24
Comments
👍🏻 . It'd be good to open an issue for the sharing buttons too.
👍🏻 . could also open an issue for that, seems like it's something most themes would want to do |
Found the issue for the Sharing block: Automattic/jetpack#19694 |
I'm guessing we'll be able to simply embed the shortcodes, like we did in #35 (comment) |
Actually, I enabled the Sharing and Likes modules, and they're showing up now. The Like button is stuck in the loading state, though. We'll need to style them too. |
I followed up on the Likes loading issue, this is ultimately a bug between Jetpack and Core. The Jetpack Likes script is registered too late for FSE themes, but loaded at the right time for Classic themes due to a load ordering difference between the types of themes. https://core.trac.wordpress.org/ticket/54529 is a core work around. A workaround for this site temporarily can be:
|
Just noting that per #97 the share/like features are disabled temporarily for SOTW |
👍🏻 I added them back now that it's over |
The current News site includes these buttons at the bottom of single posts, and the new design also incorporates them.
As noted in #21, Jetpack does not yet have site blocks for the Like feature or for the social sharing buttons. There's an issue for Likes, but I haven't been able to find one for the sharing buttons.
Until Jetpack creates these site blocks, the only way I can see to include these features in block templates would be to create a custom block that simply outputs a server-side render of the two features. Are there other options?
Also of note, the new design calls for several style changes to the Like button and related content (such as the row of avatars of users who have already liked). However, since all of that content gets loaded via an iframe, I suspect that most customization is not possible.
The text was updated successfully, but these errors were encountered: