Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Add the word Theme: to img alts for themes on settings modal #14

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sejas
Copy link
Contributor

@sejas sejas commented Aug 24, 2023

Description

It adds modifies the theme image alts on settings modal so they are different from the text below.

Testing instructions

  • In a terminal run:
    • yarn install
    • composer install
    • yarn wp-env start # to start the main server
  • In a new terminal run:
    • cd source/wp-content/themes/wporg-wasm/src/wasm-demo
    • nvm use v14.21.3
    • yarn install
    • yarn start # to start the wasm demo block
  • Go to /wp-admin
  • Activate the Wasm theme if it's not active yet.
  • Create a new page
  • Embed the block wasm demo
  • View the forntend page
  • Click on settings button
  • Inspect the theme images
  • Observe the alt images are different from the text below.
  • Couldn't reproduce the issue using axe chrome extension

Screenshot

Before
Screenshot 2023-08-24 at 16 01 04

After
Screenshot 2023-08-24 at 16 02 17

Copy link

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Well done!

Screenshot 2023-09-18 at 2 47 13 PM

@adamziel adamziel merged commit bd428f9 into WordPress:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPress Playground Demo: The Settings modal images have alt tag attributes that are duplicated as text
3 participants