Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade storybook to 7.6.20 to fix vulnerabilities #3047

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mannycarrera4
Copy link
Contributor

Summary

There were a few security concerns in storybook. Although these seem to be fixed in 8.2 and later, we're still on 7.x. More info can be found here.

Release Category

Dependencies


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Copy link

cypress bot commented Nov 8, 2024

Workday/canvas-kit    Run #8036

Run Properties:  status check passed Passed #8036  •  git commit f5a1c2f169 ℹ️: Merge 352a233fa913d79333183a2642a40617666df2e4 into 802784764d4cd8f030cf5908d0c0...
Project Workday/canvas-kit
Branch Review mc-fix-storybook-vuln
Run status status check passed Passed #8036
Run duration 04m 01s
Commit git commit f5a1c2f169 ℹ️: Merge 352a233fa913d79333183a2642a40617666df2e4 into 802784764d4cd8f030cf5908d0c0...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 32
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1093
View all changes introduced in this branch ↗︎
UI Coverage  21.89%
  Untested elements 1632  
  Tested elements 455  
Accessibility  99.17%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 182  

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Code is ready for review
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant