Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathLooksLikeCode to exclude build folder #24

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

smaifullerton-wk
Copy link
Contributor

@smaifullerton-wk smaifullerton-wk commented Jul 12, 2019

Motivation

Codemods run on the build/ folder after the package is built. Not only do we not want to do this, it can cause generatePatches() to throw an exception here and the codemod will fail: https://github.com/Workiva/dart_codemod/blob/master/lib/src/suggestors.dart#L191

Changes

Exclude paths starting with build/ from the "looking like code" filter.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • CI passes

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@smaifullerton-wk smaifullerton-wk changed the title Fix pathLooksLikeCode to exclude build/test and build/packages Fix pathLooksLikeCode to exclude build folder Jul 12, 2019
@georgelesica-wf
Copy link

QA +1

@georgelesica-wf
Copy link

+1

@georgelesica-wf
Copy link

@Workiva/release-management-p

@rmconsole3-wf rmconsole3-wf merged commit a37a8a5 into master Jul 15, 2019
@rmconsole3-wf rmconsole3-wf deleted the fix-pathLooksLikeCode-bug branch July 15, 2019 15:17
@joebingham-wk joebingham-wk mentioned this pull request Aug 19, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants