Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-3815 Add OSS licenses #5

Merged
merged 2 commits into from
Jan 15, 2019
Merged

AF-3815 Add OSS licenses #5

merged 2 commits into from
Jan 15, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Jan 15, 2019

Description

Adds the OSS licenses.

Also adds a change in 8e35898 (sorting the file paths) to ensure a deterministic order of iteration of the files returned from a FileQuery. Without this, tests were failing intermittently on CI and it's probably useful/logical to iterate over files in alphabetical order anyway.

Code Review

@corwinsheahan-wf @sebastianmalysa-wf @robbecker-wf
fyi @shanesizer-wf

@rmconsole-wf
Copy link

rmconsole-wf commented Jan 15, 2019

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

	When this pull is merged I will add it to the following release:
	Version: dart_codemod 0.1.0
	Release Ticket(s): None


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Monday, January 14 10:30 PM CST

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf evanweible-wf changed the title Add OSS licenses AF-3815 Add OSS licenses Jan 15, 2019
@georgelesica-wf
Copy link

+1

@georgelesica-wf
Copy link

@Workiva/release-management-p

@rmconsole-wf
Copy link

@georgelesica-wf I will not merge this because:

  • 'Dependency Scan Clean' is False
  • dependencies not scanned

@georgelesica-wf
Copy link

+1

@rmconsole-wf
Copy link

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants