Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated commands with new dart commands #55

Merged
merged 3 commits into from
May 10, 2022

Conversation

sourcegraph-wk
Copy link

This Sourcegraph batch replaces deprecated commands from the Dart SDK with the new ones.
All new CLI commands now live under the main dart executable. See this issue for the details
dart-lang/sdk#46100

This PR might need to be checked or tweaked for possible errors in the arguments to
dart analyze and dart format since they take slightly different arguments than the original.
In most cases for analyze all the arguments can be removed and it can just be dart analyze.

Some of the argument changes were difficult to match and replace in an automated way. Since
there are only a few places that might break, it'll be easier to let the batch create the PR
and then manually adjust them.

Argument changes for dartfmt -> dart format

-w should be removed automatically since overwriting files is now the default. But, if you spot one, remove it.
--dry-run is not a supported argument now. Replace with --set-exit-if-changed -o none

repos that look like they will need updates for dart format

  • abide
  • abide_archived
  • bender.dart
  • unscripted (unused repo)

Argument changes for dartanalyzer -> dart analyze

--no-hints and --no-lints are removed

repos that look like they will need updates for dart analyze

  • user_analytics

QA steps:

  • CI passing is a great start since these commands are usually called in the dockerfile, shell scripts, or skynet
  • Check the changeset and if there are scripts that are only run locally and not in CI, try running them locally to verify they work
  • If the PR has changes to dart analyze or dart format check the arguments
  • Lastly, look for replacements that matched in the wrong place and should be undone or fixed

Created by Sourcegraph batch change Workiva/dart_commands.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

evanweible-wf
evanweible-wf previously approved these changes Apr 24, 2022
@evanweible-wf
Copy link
Contributor

QA +1 CI passes

@todbachman-wf
Copy link
Member

@Workiva/release-management-pp

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit a0113a8 into master May 10, 2022
@rmconsole3-wf rmconsole3-wf deleted the batch/fea/dart_commands branch May 10, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants