Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEA-661: Update to analyer v2 #62

Merged
merged 2 commits into from
Sep 20, 2022
Merged

FEA-661: Update to analyer v2 #62

merged 2 commits into from
Sep 20, 2022

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Sep 20, 2022 •
edited
Loading

Motivation

Update to analyzer v2 so that consumers can use this package with that dependency.

Changes

  • Update analyzer dependency to ^2.0.0
  • Address usages of analyzer APIs (some things were deprecated, some things were made non-nullable which makes certain null checks and conditional paths unnecessary)

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole7-wk rmconsole7-wk changed the title Update to analyer v2 FEA-661 Update to analyer v2 Sep 20, 2022
@bender-wk bender-wk changed the title FEA-661 Update to analyer v2 FEA-661: Update to analyer v2 Sep 20, 2022
@evanweible-wf
Copy link
Contributor Author

QA +1

  • CI passes with analyzer v2

@Workiva/release-management-p

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Sep 20, 2022
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit c681ac4 into master Sep 20, 2022
@rmconsole5-wk rmconsole5-wk deleted the analyzer_v2 branch September 20, 2022 20:37
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Sep 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwinsheahan-wf corwinsheahan-wf corwinsheahan-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: Patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evanweible-wf @aviary2-wf @rmconsole-wf @corwinsheahan-wf @rmconsole5-wk